Review of "Vitals" version 75

Details Page Preview

A glimpse into your computer's temperature, voltage, fan speed, memory usage, processor load, system resources, network speed and storage stats. This is a one stop shop to monitor all of your vital sensors. Uses asynchronous polling to provide a smooth user experience. Feature requests or bugs? Please use GitHub.

Extension Homepage
https://github.com/corecoding/Vitals

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:172
            this._menuStateChangeId = this.menu.connect('open-state-changed', (self, isMenuOpen) => {
                if (isMenuOpen) {
                    // make sure timer fires at next full interval
                    this._updateTimeChanged();
    
                    // refresh sensors now
                    this._quer
  • extension.js:136
            refreshButton.connect('clicked', (self) => {
                // force refresh by clearing history
                this._sensors.resetHistory();
                this._values.resetHistory(this._numGpus);
    
                // make sure timer fires at next full interval
                this._updateTimeChanged();
    
      
  • extension.js:151
            monitorButton.connect('clicked', (self) => {
                this.menu._getTopMenu().close();
                Util.spawn(this._settings.get_string('monitor-cmd').split(" "));
            })
  • extension.js:159
            prefsButton.connect('clicked', (self) => {
                this.menu._getTopMenu().close();
                this._extensionObject.openPreferences();
            })
  • extension.js:440
            item.connect('toggle', (self) => {
                let hotSensors = this._settings.get_strv('hot-sensors');
    
                if (self.checked) {
                    // add selected sensor to panel
                    hotSensors.push(self.key);
                    this._createHotItem(self.key, self.value);
         

EGO015 warning

signals connected by extension should be disconnected in disable()

Signal handler collections created in `enable()` are missing matching disconnect loops in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:395
    this._settings.connect('changed::' + key, callback)

All Versions

Previous Reviews on this Version

dlandau active
Please check those shexli messages for next time