Review of "Multi Monitor Bar" version 37

Details Page Preview

Fork of spin83's Multi Monitors. Pleaseeeee donate to support this extension :). Don't forget to star the original repository! , rate and comment

Extension Homepage
https://github.com/FrederykAbryan/multi-monitors-bar_fapv2

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • mmcalendar.js:67
                this._calendar.connect('selected-date-changed', (_calendar, datetime) => {
                    // Make the button reactive only if the selected date is not the
                    // current date.
                    this.reactive = !DateMenu._isToday(DateMenu._gDateTimeToDate(datetime));
              
  • mmoverview.js:89
    minimizedChangedId
  • mmpanel.js:805
                indicator.connect('destroy', () => {
                    delete this.statusArea[role];
                })
  • mmpanel.js:810
                indicator.connect('menu-set', () => {
                    if (!indicator.menu)
                        return;
                    this.menuManager.addMenu(indicator.menu);
                })

All Versions

Previous Reviews on this Version

AbryanPalinoan auto- rejected
Auto-rejected because of new version 38 was uploaded