Review of "Lockscreen Extension" version 15

Details Page Preview

Customize GNOME's Lockscreen from the lockscreen itself.

Extension Homepage
https://github.com/pratap-panabaka/gse-lockscreen-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO026 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • utils/confirmDialog.js

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:30
    this._settings = this.getSettings()
  • extension.js:32
    this._systemBgSettings = new Gio.Settings({schema_id: 'org.gnome.desktop.background'})

All Versions

Previous Reviews on this Version

PRATAP PANABAKA auto- rejected
Auto-rejected because of new version 16 was uploaded