Review of "Essential Tweaks" version 8

Details Page Preview

Tweak annoying defaults and enable quality of life features

Extension Homepage
https://github.com/lublst/gnome-essential-tweaks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • lib/panelCorners.js:136
    this._positionChangeHandler = Main.panel.connect('notify::position', this._updateCornerPosition.bind(this))
  • lib/panelCorners.js:137
    this._sizeChangeHandler = Main.panel.connect('notify::size', this._updateCornerPosition.bind(this))

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Lukas Bleisteiner posted a review
Changes in this version: - Support for GNOME 50 I think the issue found by Shexli is a false positive, see `panelCorners.js:228`.
fmuellner active