Review of "Noiseclapper (Soundcore Life for GNOME)" version 7

Details Page Preview

Noiseclapper is a GNOME Shell extension that allows you to control some normally phone-application exclusive settings on your Soundcore Life headphones from your GNOME desktop. Confirmed working with : - Soundcore Life P3 - Soundcore Life Q30 Allowed, but untested : - Soundcore Life Q35 - Soundcore Life Q20+ - Soundcore Life Q20 - Soundcore Life Q10 Support for your headphones could potentially be added through an issue or a pull request.

Extension Homepage
https://github.com/JordanViknar/Noiseclapper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.Noiseclapper.gschema.xml
    id='org.gnome.shell.extensions.noiseclapper' path='/org/gnome/shell/extensions/noiseclapper/'

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:23
    this.settings = this.getSettings()

All Versions

Version Status
7 Unreviewed
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected