Review of "Dim Background Windows" version 22

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:402
    meta_window.get_maximized()
  • extension.js:413
    meta_window.get_maximized()

All Versions

Version Status
23 Unreviewed
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

_stephane_ posted a review
Added Gnome 50 support, and made the regex filter in options have an immediate effect on windows, without having to close the options window.
_stephane_ posted a review
The EGO-C49-004 error is actually what looks like a false positive. The function meta_window.get_maximized() is called only if it exists, i.e. on Gnome 45-48, not Gnome 49-50. So I think that's ok.
_stephane_ auto- rejected
Auto-rejected because of new version 23 was uploaded