Review of "Dim Background Windows" version 23

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:398
    meta_window.get_maximized()
  • extension.js:409
    meta_window.get_maximized()

All Versions

Version Status
23 Unreviewed
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

_stephane_ posted a review
Added Gnome 50 support. Made the window title regex exclusion filter changes immediately visible without closing the options window. The reported error EGO-C49-004 is probably a false positive. The function meta_window.get_maximized() is only called in Gnome 45-48, not Gnome 49-50.