Review of "Kando Integration" version v0.12.0 (13)

Details Page Preview

This extension is required for Kando to work on Wayland. It allows Kando to bind global shortcuts, and provides information about your currently focused application window and the position of your mouse pointer.

Extension Homepage
https://github.com/kando-menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:103
        this._shortcuts.connect('activated', (s, shortcut) => {
          this._dbus.emit_signal('ShortcutPressed', new GLib.Variant('(s)', [shortcut]));
        })

All Versions

Version Status
v0.12.0 (13) Unreviewed
v0.11.0 (12) Active
v0.10.0 (11) Rejected
v0.9.0 (10) Active
v0.8.0 (9) Active
v0.7.0 (8) Active
v0.6.0 (7) Active
v0.5.0 (6) Active
v0.4.0 (5) Active
v0.3.1 (4) Active
v0.3.0 (3) Active
v0.2.1 (2) Rejected
v0.2.0 (1) Rejected

Previous Reviews on this Version

Simon Schneegans posted a review
The shortcuts object gets deleted by the extension on disable, so I guess we can ignore the shexli warning :)