Review of "Kando Integration" version v0.14.0 (16)

Details Page Preview

This extension is required for Kando to work on Wayland. It allows Kando to bind global shortcuts, and provides information about your currently focused application window and the position of your mouse pointer.

Extension Homepage
https://github.com/kando-menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:110
        this._shortcuts.connect('activated', (s, shortcut) => {
          this._dbus.emit_signal('ShortcutPressed', new GLib.Variant('(s)', [shortcut]));
        })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
v0.14.0 (16) Active
v0.14.0 (15) Rejected
v0.13.0 (14) Active
v0.12.0 (13) Active
v0.11.0 (12) Active
v0.10.0 (11) Rejected
v0.9.0 (10) Active
v0.8.0 (9) Active
v0.7.0 (8) Active
v0.6.0 (7) Active
v0.5.0 (6) Active
v0.4.0 (5) Active
v0.3.1 (4) Active
v0.3.0 (3) Active
v0.2.1 (2) Rejected
v0.2.0 (1) Rejected

Previous Reviews on this Version

JustPerfection active