GNOME Shell Extensions

Review of "Tactile" version 36

Details Page Preview

Tactile

by lundal

Tile windows on a custom grid using your keyboard. Type Super-T to show the grid, then type two tiles (or the same tile twice) to move the active window. The grid can be up to 4x3 (corresponding to one hand on the keyboard) and each row/column can be weighted to take up more or less space.

Extension Homepage
https://gitlab.com/lundal/tactile
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:114 
    window.maximize(Meta.MaximizeFlags.HORIZONTAL)
  • extension.js:120 
    window.maximize(Meta.MaximizeFlags.VERTICAL)
  • extension.js:109 
    window.unmaximize(Meta.MaximizeFlags.BOTH)
  • extension.js:117 
    window.unmaximize(Meta.MaximizeFlags.HORIZONTAL)
  • extension.js:123 
    window.unmaximize(Meta.MaximizeFlags.VERTICAL)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:108 
    window.get_maximized()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:15 
    this._settings = this.getSettings()

All Versions