Review of "Tactile" version 38

Details Page Preview

Tile windows on a custom grid using your keyboard. Type Super-T to show the grid, then type two tiles (or the same tile twice) to move the active window. The grid can be up to 4x3 (corresponding to one hand on the keyboard) and each row/column can be weighted to take up more or less space.

Extension Homepage
https://gitlab.com/lundal/tactile

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 1

Shexli found 4 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:111
    window_GNOME_48_AND_BELOW.maximize(Meta.MaximizeFlags.HORIZONTAL)
  • extension.js:117
    window_GNOME_48_AND_BELOW.maximize(Meta.MaximizeFlags.VERTICAL)
  • extension.js:106
    window_GNOME_48_AND_BELOW.unmaximize(Meta.MaximizeFlags.BOTH)
  • extension.js:114
    window_GNOME_48_AND_BELOW.unmaximize(Meta.MaximizeFlags.HORIZONTAL)
  • extension.js:120
    window_GNOME_48_AND_BELOW.unmaximize(Meta.MaximizeFlags.VERTICAL)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:105
    window_GNOME_48_AND_BELOW.get_maximized()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:12
    this._settings = this.getSettings()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

lundal posted a review
The code changes are because of updated typescript types. Regarding shexli: - EGO-C49-003 and EGO-C49-004 are because of backwards compatibility. Use of the old api is behind a feature check. - EGO-L-005 is plain wrong. The object is set to undefined in disable(). - EGO-M-004 does not make any sense to me.
JustPerfection active