Review of "Add Custom Text to Workspace Indicators" version 20

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:217
    GLib.spawn_command_line_sync('uname -r')

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:41
    this._customIndicator = new St.Label(labelObj)
  • extension.js:38
    this._customLabel = new St.Label(labelObj)
  • extension.js:17
    this._customLogo = new St.Icon()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:170
    this._activeWsChangedId = global.workspace_manager.connect('active-workspace-changed', this._onWorkspaceChanged.bind(this))
  • extension.js:153
    this._customTextId = this._settings.connect('changed::custom-text', this._setCustomLabel.bind(this))
  • extension.js:165
    this._onCustomIndicatorColorChangedId = this._settings.connect('changed::indicator-color', this._onIndicatorColorChange.bind(this))
  • extension.js:162
    this._onLabelColorChangedId = this._settings.connect('changed::label-color', this._onLabelColorChange.bind(this))
  • extension.js:159
    this._onLogoChangedId = this._settings.connect('changed::logo-path', this._onLogoChange.bind(this))
  • extension.js:156
    this._onPillsColorChangedId = this._settings.connect('changed::pills-color', this._onPillsColorChange.bind(this))
  • extension.js:141
    this._pillsVisibilityId = this._settings.connect('changed::hide-pills', this._pillsVisibilityChange.bind(this))
  • extension.js:150
    this._showCustomIndicatorsId = this._settings.connect('changed::show-custom-indicator', this._setCustomIndicator.bind(this))
  • extension.js:147
    this._showCustomTextId = this._settings.connect('changed::show-custom-text', this._setLabel.bind(this))
  • extension.js:144
    this._showLogoId = this._settings.connect('changed::show-logo', this._showLogo.bind(this))
  • extension.js:171
    this._wSNumberChangedId = global.workspace_manager.connect('notify::n-workspaces', this._onWorkspaceChanged.bind(this))

All Versions

Previous Reviews on this Version

PRATAP PANABAKA auto- rejected
Auto-rejected because of new version 21 was uploaded