Review of "Add Custom Text to Workspace Indicators" version 21

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:54
    this._customIndicator = new St.Label(labelProps)
  • extension.js:53
    this._customLabel = new St.Label(labelProps)
  • extension.js:48
            this._customLogo = new St.Icon({
                gicon: Gio.icon_new_for_string(this._settings.get_string('logo-path')),
                icon_size: Main.panel.height,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:54
    this._customIndicator = new St.Label(labelProps)
  • extension.js:53
    this._customLabel = new St.Label(labelProps)
  • extension.js:48
            this._customLogo = new St.Icon({
                gicon: Gio.icon_new_for_string(this._settings.get_string('logo-path')),
                icon_size: Main.panel.height,
            })

All Versions

Previous Reviews on this Version

PRATAP PANABAKA auto- rejected
Auto-rejected because of new version 22 was uploaded