Review of "Customize Clock on Lock Screen" version 25

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • ModifiedClock.js:304
                this._analogArea.connect('repaint', area => {
                    const cr = area.get_context();
                    const [width, height] = area.get_surface_size();
                    this._paintAnalogClock(cr, width, height);
                })
  • ModifiedClock.js:325
                this._ledArea.connect('repaint', area => {
                    const cr = area.get_context();
                    const [width, height] = area.get_surface_size();
                    this._paintLedClock(cr, width, height);
                })
  • ModifiedClock.js:211
    this._wallClock.connect('notify::clock', this._updateClock.bind(this))

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:29
        disable() {
            this._dialog._stack.remove_child(this._dialog._clock);
            this._dialog._stack.add_child(this._originalClock);
    
            this._dialog._promptBox.set_y_align(Clutter.ActorAlign.DEFAULT);
    
            this._dialog._clock.destroy();
            this._dialog._clock = null;
            thi

All Versions

Previous Reviews on this Version

PRATAP PANABAKA auto- rejected
Auto-rejected because of new version 26 was uploaded