EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• store.js:45

      console.log(
        EXTENSION_UUID,
        "Failed to create cache dir, extension likely won't work",
        CACHE_DIR,
      )

• store.js:178

  console.log(EXTENSION_UUID, 'Unknown op type, aborting load.', opType)

• store.js:189

  console.log(EXTENSION_UUID, 'Parsing error')

• store.js:221

  console.log(EXTENSION_UUID, 'Failed to move database file')

• store.js:224

  console.log(EXTENSION_UUID, 'Crash moving database file')

• store.js:190

  console.error(e)

• store.js:225

  console.error(e)

• store.js:267

  console.error(e)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:1042

      this._notifSource.connect('destroy', () => {
        this._notifSource = undefined;
      })

• extension.js:246

      this.menu.actor.connect('key-press-event', (_, event) =>
        this._handleGlobalKeyEvent(event),
      )

• extension.js:132

      this.menu.connect('open-state-changed', (self, open) => {
        if (open) {
          this._setMenuWidth();
          this.searchEntry.set_text('');
          this._searchFocusHackCallbackId = GLib.timeout_add(
            GLib.PRIORITY_DEFAULT,
            1,
            () => {
              global.stage.se

• extension.js:215

      this.privateModeMenuItem.connect('toggled', () => {
        this.settings.set_boolean(
          SettingsFields.PRIVATE_MODE,
          this.privateModeMenuItem.state,
        );
      })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:626

      this._pasteHackCallbackId = GLib.timeout_add(
        GLib.PRIORITY_DEFAULT,
        1, // Just post to the end of the event loop
        () => {
          const SHIFT_L = 42;
          const INSERT = 110;
  
          const eventTime = Clutter.get_current_event_time() * 1000;
          VirtualKeyboard().notify

• extension.js:136

          this._searchFocusHackCallbackId = GLib.timeout_add(
            GLib.PRIORITY_DEFAULT,
            1,
            () => {
              global.stage.set_key_focus(this.searchEntry);
              this._searchFocusHackCallbackId = undefined;
              return false;
            },
          )