Review of "System HUD" version 20

Details Page Preview

Clean UI system monitor for CPU, GPU, memory, storage, network, power.

Extension Homepage
https://github.com/LalaloyXyz/System-info-HUD

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • uiManager.js:641
    St.Clipboard.get_default()

All Versions

Previous Reviews on this Version

SriramRamkrishna posted a review
I checked the Shexli warning, and I see no issues with the clipboard. As there is a large change, I'm deferring to a more seasoned reviewer.
fmuellner active
I think the clipboard warning is mostly about possible privacy/security issues when reading its contents. I'm not sure whether there are similar concerns when writing to the clipboard, I opened https://gitlab.gnome.org/Infrastructure/extensions-web/-/work_items/380 for clarification (and a possible shexli improvement). In any case, copying to the clipboard in a response to a "copy to clipboard" user action is clearly fine.