Review of "gFinder" version 3

Details Page Preview

A New AppMenu **features ** Menu icon padding is improved. Show Files when no focus app is available. Indicate window title even when one window is opened.

Extension Homepage
https://github.com/howbea/gappmenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:60
            this._changedid = textureCache.connect('icon-theme-changed',
                this._onIconThemeChanged.bind(this))

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Inactive

Previous Reviews on this Version

howbea auto- rejected
Auto-rejected because of new version 4 was uploaded