Review of "GFinder" version 6

Details Page Preview

App menu

Extension Homepage
https://github.com/howbea/gappmenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:283
    this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:107
            this._settings.connect('changed::single-window', () => {
                this._buildMenu();
            })

All Versions

Version Status
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Inactive

Previous Reviews on this Version

howbea auto- rejected
Auto-rejected because of new version 7 was uploaded