Review of "GFinder" version 10

Details Page Preview

App menu

Extension Homepage
https://github.com/howbea/gappmenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:270
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:120
            this._bookmarksFileMonitor.connect(
                'changed',
                () => {
                    if (this._targetApp?.get_id() === 'org.gnome.Nautilus.desktop')
                        this._buildMenu();
                }
            )

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Please fix the issues mentioned in Shexli. Also, use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)