Review of "Application Tabs" version 40

Details Page Preview

Window tabs for the focused application in the GNOME top bar or on a draggable floating bar. • Panel mode: tabs in the top bar • Standalone mode: floating tab bar (optional hide top bar, slide animation) • Click tab to focus or minimize; close button and right-click window menu • Drag to reorder tabs; add-tab and recent-windows menus • Per-app fixed panel/standalone mode; customizable tab styles Questions and feature requests: repository issue tracker.

Extension Homepage
https://github.com/hhoao/app_tabs

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • src/AppTab.js:411
    St.Clipboard.get_default()

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • src/AppTab.js:339
                        GLib.spawn_command_line_sync(
                            `xprop -id ${winId} -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS "0x2, 0x0, 0x0, 0x0, 0x0"`
                        )
  • src/AppTab.js:343
                        GLib.spawn_command_line_sync(
                            `xprop -id ${winId} -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS "0x2, 0x0, 0x1, 0x0, 0x0"`
                        )
  • src/AppTab.js:389
    GLib.spawn_command_line_sync(`ps -p ${pid} -o comm=`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/utils/WindowUtils.js:28
    file.load_contents(null)

All Versions

Previous Reviews on this Version

fmuellner active