EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• extension.js:15

  console.log('Executor enabled')

• extension.js:125

  console.log('Executor stopped')

• extension.js:177

  console.log('Error in json file for location: ' + location.name)

• extension.js:199

  console.log('No commands specified: ' + location.name)

• extension.js:255

                              console.log(
                                  'Executor: error in command "' +
                                      command.command +
                                      '": ' +
                                      (stderr ? stderr.trim() : GLib.strerror(status))
             

• extension.js:325

  console.log('Caught exception while setting output: ' + e)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

• prefs.js:13

      getPreferencesWidget() {
          const postrans = {
              0: _('Left'),
              1: _('Center'),
              2: _('Right'),
          };
  
          const settings = this.getSettings();
  
          let prefsWidget = new Gtk.Grid({visible: true, column_homogeneous: true});
          this.notebook