Review of "Daily Bing Wallpaper and Accent Color" version 1.2.0 (5)

Details Page Preview

Simple, unobtrusive GNOME extension that automatically sets the desktop wallpaper to Bing's image of the day and optionally uses the dominant color to set the system accent color. No panel applets, no popups, no extraneous features. Works efficiently in the background without requiring user interaction. Disclaimer: "Bing" is a trademark of Microsoft Corporation. This project is not affiliated with or endorsed by Microsoft. All images remain the property of their respective copyright holders and are presumed to be intended for personal, non-commercial wallpaper use only. No images are redistributed or modified by this extension.

Extension Homepage
https://codeberg.org/haydn/dailybingwallpaper/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • accentColor.js:214
    interfaceSettings.run_dispose()
  • extension.js:173
    bgSettings.run_dispose()

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • accentColor.js:26
    new AccentColour('blue', 0, 115, 255)
  • accentColor.js:27
    new AccentColour('teal', 0, 255, 255)
  • accentColor.js:28
    new AccentColour('green', 0, 191, 0)
  • accentColor.js:29
    new AccentColour('yellow', 200, 150, 0)
  • accentColor.js:30
    new AccentColour('orange', 237, 91, 0)
  • accentColor.js:31
    new AccentColour('red', 230, 0, 26)
  • accentColor.js:32
    new AccentColour('pink', 230, 138, 182)
  • accentColor.js:33
    new AccentColour('purple', 145, 65, 172)
  • accentColor.js:34
    new AccentColour('slate', 166, 166, 166)

All Versions

Version Status
1.2.0 (5) Active
1.1.1 (4) Active
1.1.0 (3) Active
1.0.1 (2) Active
1.0 (1) Rejected

Previous Reviews on this Version

fmuellner active