Review of "WSP (Windows Search Provider)" version 50.0 (26)

Details Page Preview

Search and control windows from Activities overview

Extension Homepage
https://github.com/G-dH/windows-search-provider

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 2

Shexli found 5 issues that may need reviewer attention.

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 56% of identifiers are 1–2 characters (avg length 5.6).

Code must not be obfuscated

  • extension.js
    short identifier ratio: 56%, identifiers scored: 25

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • listSearchResult.js:161
    St.Clipboard.get_default()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • highlighter.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • dashIcon.js:154
            this.toggleButton = new St.Button({
                style_class: 'show-apps',
                track_hover: true,
                can_focus: true,
                toggle_mode: false,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • dashIcon.js:154
            this.toggleButton = new St.Button({
                style_class: 'show-apps',
                track_hover: true,
                can_focus: true,
                toggle_mode: false,
            })

All Versions

Version Status
50.0 (26) Active
49.0 (25) Active
48.0 (24) Active
47.2 (23) Active
47.2 (22) Rejected
44.8 (21) Active
44.8 (20) Rejected
47.2 (19) Active
47.1 (18) Inactive
47.0 (17) Inactive
47.0 (16) Rejected
47.0 (15) Rejected
44.6 (14) Active
46.6 (13) Inactive
44.5 (12) Inactive
46.5 (11) Inactive
44.4 (10) Inactive
46.4 (9) Inactive
44.3 (8) Rejected
46.3 (7) Rejected
46.3 (6) Inactive
44.3 (5) Inactive
46.3 (4) Rejected
46.3 (3) Rejected
44.1 (2) Inactive
46.1 (1) Inactive

Previous Reviews on this Version

fmuellner active