Review of "TeaTimer" version 17

Details Page Preview

A tea steeping timer Follow-up Fork of https://extensions.gnome.org/extension/604/teatime

Extension Homepage
https://github.com/zeners/gnome-shell-teatime/tree/teatimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
17 Active
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Inactive
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
Just as a side note, you could use ``` this._settings.connectObject( "changed::" + this.config_keys.steep_times, this._updateTeaList.bind(this), "changed::" + this.config_keys.graphical_countdown, this._updateCountdownType.bind(this), this); ``` to disconnect the signals automatically when the indicator is destroyed. The menu signal looks like a false positive from shexli to me, as the menu is destroyed with the indicator. It isn't wrong to disconnect those signals explicitly of course.