Review of "Iqair Gnome Extension" version 36

Details Page Preview

The unofficial Gnome extension for tracking air quality in real-time, using airvisual.com's IQAir service. Token apply: https://dashboard.iqair.com/personal/api-keys

Extension Homepage
https://github.com/wotmshuaisi/iqairGnomeExtension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:192
          this._settings.connect(`changed::${key}`, () => {
            this.disable();
            this.enable();
          })

All Versions

Previous Reviews on this Version

fmuellner active