Review of "WireGuard-VPN-extension" version 17

Details Page Preview

Enable/Disable Wireguard tunnels

Extension Homepage
https://github.com/SJBERTRAND/gnome-wireguard-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:151
    Extension.lookupByUUID('gnome-wireguard-extension@SJBERTRAND.github.com')
  • extension.js:168
    Extension.lookupByUUID('gnome-wireguard-extension@SJBERTRAND.github.com')

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:184
                client.connect('connection-added', (_client, _connection) => {
                    WireGuard._create_new_switches(this.menu, client, _connection, icon);
                })
  • extension.js:190
                client.connect('connection-removed', (_client, _connection) => {
                    WireGuard._update_switches(this.menu, client, _connection, icon);
                })
  • extension.js:196
                client.connect('device-added', (_client, _device) => {
                    WireGuard._update_switches_toggle_state(this.menu, client, _device, icon);
                })
  • extension.js:202
                client.connect('device-removed', (_client, _device) => {
                    WireGuard._update_switches_toggle_state(this.menu, client, _device, icon);
                })

All Versions

Version Status
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Inactive
8 Rejected
7 Rejected
6 Active
5 Active
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

fmuellner active