Review of "Another Wallpaper Changer" version 2

Details Page Preview

A simple wallpaper changer for GNOME, based on wallpaper-changer@jomik.org. If you find it useful, please consider supporting the project and leave a comment with your feature requests!

Extension Homepage
https://github.com/josFx13/gnome_another_wallpaper_changer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • prefs.js:55
    console.log('selection', path)
  • prefs.js:65
    console.log('Folder selection cancelled or failed', err)
  • prefs.js:78
    console.log('selection', path)
  • prefs.js:84
    console.log('Folder selection cancelled or failed', err)
  • prefs.js:113
    console.log(`Successfully opened: ${url}`)
  • prefs.js:115
    console.error(`Failed to open link: ${e.message}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.wallpaperchanger.gschema.xml
    id='org.gnome.shell.extensions.jfx-wallpaperchanger' path='/org/gnome/shell/extensions/jfx-wallpaperchanger/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:217
                this.monitor.connect('changed', (_fileMonitor, file, otherFile, eventType) => {
                    log({ _fileMonitor, file, otherFile, eventType })
                    log(Gio.FileMonitorEvent.CHANGED, Gio.FileMonitorEvent.MOVED_OUT, Gio.FileMonitorEvent.MOVED_IN)
    
    
                    switch (eve

All Versions

Version Status
2 Unreviewed
1 Rejected