Review of "Another Wallpaper Changer" version 1

Details Page Preview

A simple wallpaper changer for GNOME, based on wallpaper-changer@jomik.org. If you find it useful, please consider supporting the project and leave a comment with your feature requests!

Extension Homepage
https://github.com/josFx13/gnome_another_wallpaper_changer

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 2

Shexli found 5 issues that may need reviewer attention.

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gtk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • extension.js:5
    import Gtk from 'gi://Gtk?version=4.0';

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • prefs.js:55
    console.log('selection', path)
  • prefs.js:65
    console.log('Folder selection cancelled or failed', err)
  • prefs.js:78
    console.log('selection', path)
  • prefs.js:84
    console.log('Folder selection cancelled or failed', err)
  • prefs.js:113
    console.log(`Successfully opened: ${url}`)
  • prefs.js:115
    console.error(`Failed to open link: ${e.message}`)

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.wallpaperchanger.gschema.xml
    id='org.gnome.shell.extensions.jfx-wallpaperchanger' path='/org/gnome/shell/extensions/jfx-wallpaperchanger/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:244
    this.monitor.connect('changed', () => { this._wallpapersChanged() })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` must be a non-empty list of supported GNOME Shell versions.

metadata.json must be well-formed

  • metadata.json
    shell-version=[]

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

fmuellner rejected
You must not import Gtk (or Gdk or Adwaita) in the shell process. The metadata contains an empty "shell-version" array, which means the extension is not marked as compatible with *any* shell version.