Review of "Another Wallpaper Changer" version 3

Details Page Preview

A simple wallpaper changer for GNOME, based on wallpaper-changer@jomik.org. If you find it useful, please consider supporting the project and leave a comment with your feature requests!

Extension Homepage
https://github.com/josFx13/gnome_another_wallpaper_changer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:231
                this.monitorEvId = this.monitor.connect('changed', (_fileMonitor, file, otherFile, eventType) => {
                    // log({ _fileMonitor, file, otherFile, eventType })
                    // log(Gio.FileMonitorEvent.CHANGED, Gio.FileMonitorEvent.MOVED_OUT, Gio.FileMonitorEvent.MOVED_IN, Gio.

All Versions

Version Status
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Please remove version from the import (line 1 `prefs.js`)