GNOME Shell Extensions

Review of "Activity App Launcher" version 51

Details Page Preview

Activity App Launcher

by rastersoft

Integrates a category-based application launcher in the activities window. IMPORTANT: it needs the 'gnome-menus' and 'libgnome-menu-3-dev'; they must be installed in the system before installing this extension.

Extension Homepage
https://gitlab.com/rastersoft/activityAppLauncher
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:91 
            this._appsInnerContainer = new St.BoxLayout({
            vertical: true,
            x_align: Clutter.ActorAlign.START,
            y_align: Clutter.ActorAlign.CENTER,
            x_expand: false,
            y_expand: true
        })
  • extension.js:98 
    this._constraint = new BaseConstraint()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:173 
                            icon.connect('notify::pressed', () => {
                            if (icon.pressed)
                                this.updateDragFocus(icon);
                        })

All Versions

Previous Reviews on this Version

rastersoft auto- rejected
Auto-rejected because of new version 52 was uploaded