Review of "Activity App Launcher" version 56

Details Page Preview

Integrates a category-based application launcher in the activities window. IMPORTANT: it needs the 'gnome-menus' and 'libgnome-menu-3-dev'; they must be installed in the system before installing this extension.

Extension Homepage
https://gitlab.com/rastersoft/activityAppLauncher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please don't use optional chaining for `destroy()` like that. Either you know there is a destroy or if there isn't, simply don't call it. So, remove line 200 and on 210 do this instead: ```js this._appsInnerContainer?.destroy(); ```
rastersoft posted a review
But... If I remove it, Shexli complains!!!!
JustPerfection posted a review
Shexli is in beta and does false positive here and there. It needs improvement. You can also create a `destroy()` function in `BaseConstraint` but I wouldn't do that since that would be there to only satisfy false positive.
JustPerfection posted a review
The Shexli issue: https://gitlab.gnome.org/Infrastructure/extensions-web/-/work_items/391