Review of "Shortcuts" version 50.1 (39)

Details Page Preview

This shows a pop-up of useful keyboard shortcuts when Ctrl + Alt + Super + S is pressed (hotkey can be changed in settings)

Extension Homepage
https://gitlab.com/paddatrapper/shortcuts-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:292
    file.load_contents(null)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:381
                this._button = new St.Bin({
                    style_class: "panel-button",
                    reactive: true,
                    can_focus: true,
                    x_expand: true,
                    y_expand: false,
                    track_hover: true,
                })
  • extension.js:114
                    this._child1_panel = new St.BoxLayout({
                        style_class: "child-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })
  • extension.js:118
                    this._child2_panel = new St.BoxLayout({
                        style_class: "child-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })
  • extension.js:125
                        this._child3_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:132
                        this._child4_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:139
                        this._child5_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:107
                    this._main_panel = new St.BoxLayout({
                        style_class: "panel-boxlayout",
                        orientation: Clutter.Orientation.HORIZONTAL,
                    })
  • extension.js:103
                    this._stage = new St.BoxLayout({
                        style_class: "background-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:114
                    this._child1_panel = new St.BoxLayout({
                        style_class: "child-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })
  • extension.js:118
                    this._child2_panel = new St.BoxLayout({
                        style_class: "child-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })
  • extension.js:125
                        this._child3_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:132
                        this._child4_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:139
                        this._child5_panel = new St.BoxLayout({
                            style_class: "child-boxlayout",
                            orientation: Clutter.Orientation.VERTICAL,
                        })
  • extension.js:107
                    this._main_panel = new St.BoxLayout({
                        style_class: "panel-boxlayout",
                        orientation: Clutter.Orientation.HORIZONTAL,
                    })
  • extension.js:103
                    this._stage = new St.BoxLayout({
                        style_class: "background-boxlayout",
                        orientation: Clutter.Orientation.VERTICAL,
                    })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:395
    this._button.connect("button-press-event", this._onButtonPress.bind(this))

All Versions

Version Status
50.1 (39) Unreviewed
50.0 (38) Active
49.2 (37) Inactive
49.1 (36) Inactive
49.0 (35) Inactive
48.0 (34) Active
48.0 (33) Inactive
47.2 (32) Inactive
47.2 (31) Inactive
47.1 (30) Inactive
47.1 (29) Inactive
47.1 (28) Inactive
47.0 (27) Inactive
46.1 (26) Active
46.0 (25) Inactive
45.0 (24) Inactive
23 Inactive
22 Inactive
21 Inactive
20 Inactive
19 Inactive
18 Rejected
17 Inactive
16 Rejected
15 Active
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Inactive
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Rejected