Review of "Matrix Status Monitor" version 8

Details Page Preview

High-performance Matrix notification monitor for GNOME Shell.

Extension Homepage
https://github.com/nurefexc/matrix-status

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:211
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:100
    console.warn(`[Matrix-Status] Failed to load visit counts: ${e.message}`)
  • extension.js:110
    console.warn(`[Matrix-Status] Failed to save visit counts: ${e.message}`)
  • extension.js:851
    console.warn(`[Matrix-Status] Auth failed (${msg.status_code}). Resetting sync token.`)
  • extension.js:854
    console.warn(`[Matrix-Status] Sync failed with status: ${msg.status_code}`)
  • extension.js:567
    console.error(`[Matrix-Status] QR generation error: ${e.message}`)
  • extension.js:598
    console.error(`[Matrix-Status] Action box error: ${e.message}`)
  • extension.js:858
    console.error(`[Matrix-Status] Sync error: ${e.message}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1008
    this._settings.connect('changed::client-type', rebuildMenu)
  • extension.js:1009
    this._settings.connect('changed::generate-qr-code-enable', rebuildMenu)
  • extension.js:1010
    this._settings.connect('changed::notifications-enable', rebuildMenu)
  • extension.js:1003
    this._settings.connect('changed::sync-interval', () => this._restartTimer())

All Versions

Version Status
9 Unreviewed
8 Active
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Approved but please remove unnecessary try-catch (line 561 `extension.js`).