Review of "Matrix Status Monitor" version 9

Details Page Preview

High-performance Matrix notification monitor for GNOME Shell.

Extension Homepage
https://github.com/nurefexc/matrix-status

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:132
    file.load_contents(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:207
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:974
    this._settings.connect(`changed::${SETTINGS_KEYS.SYNC_INTERVAL}`, () => this._restartTimer())
  • extension.js:979
    this._settings.connect(`changed::${SETTINGS_KEYS.CLIENT_TYPE}`, rebuildMenu)
  • extension.js:980
    this._settings.connect(`changed::${SETTINGS_KEYS.GENERATE_QR_ENABLE}`, rebuildMenu)
  • extension.js:981
    this._settings.connect(`changed::${SETTINGS_KEYS.NOTIFICATIONS_ENABLE}`, rebuildMenu)

All Versions

Version Status
9 Unreviewed
8 Active
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Rejected
1 Rejected