GNOME Shell Extensions

Review of "Timezone" version 27

Details Page Preview

Timezone

by jwendell

See people with their timezones from the Shell

Extension Homepage
https://github.com/jwendell/gnome-shell-extension-timezone
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tests/test-gnome-apis.js
  • tests/test-people-parsing.js
  • tests/test-runner.js
  • tests/test-settings.js
  • tests/test-timezone.js
  • tests/test-util.js

All Versions

Version Status
29 Active
28 Rejected
27 Rejected
26 Active
25 Rejected
24 Active
23 Rejected
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please fix the issues mentioned in Shexli and I'll review the entire code base then.