GNOME Shell Extensions

Review of "Timezone" version 28

Details Page Preview

Timezone

by jwendell

See people with their timezones from the Shell

Extension Homepage
https://github.com/jwendell/gnome-shell-extension-timezone
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
29 Active
28 Rejected
27 Rejected
26 Active
25 Rejected
24 Active
23 Rejected
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import: - line 3 `avatarCache.js` - line 2 `util.js` 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. You should call `abort()` and nulled out on disable (line 67 `util.js`): - [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)