Review "MX3 Control" version 1 - GNOME Shell Extensions

Review of "MX3 Control" version 1

Details Page Preview

MX3 Control

by enbonnet

Quick Settings control for the mx3-linux-driver daemon for Logitech MX Master 3 mice.

Extension Homepage: https://github.com/enBonnet/mx3-control-gnome

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

src/mx3-manager.js:44
```
GLib.file_get_contents(MX3_PID_FILE)
```

All Versions

Version	Status
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected June 4, 2026

1. Wrong value for `settings-schema` in `metadata.json`. Your actual schema ends with `mx3-gnome` not `mx3-control-gnome`. 2. Please use aysnc for reading file content since you are in shell process (line 44 `src/mx3-manager.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions