GNOME Shell Extensions

Review of "MX3 Control" version 2

Details Page Preview

MX3 Control

by enbonnet

Quick Settings control for the mx3-linux-driver daemon for Logitech MX Master 3 mice.

Extension Homepage
https://github.com/enBonnet/mx3-control-gnome
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/mx3-manager.js:62 
    commFile.load_contents(this._cancellable)

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please fix the issue mentioned in the sexli.