GNOME Shell Extensions

Review of "MX3 Control" version 4

Details Page Preview

MX3 Control

by enbonnet

Quick Settings control for the mx3-linux-driver daemon for Logitech MX Master 3 mice.

Extension Homepage
https://github.com/enBonnet/mx3-control-gnome
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Timeout should be removed on destroy and before creating a new one (line 200 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)