Review of "O Tiling Shell" version 2.8.11 (5)

Details Page Preview

Auto tiling extension for GNOME Shell with active hint border, customizable workspace overview and theme consistency. O Tiling Shell is a free, open-source auto-tiling extension for GNOME Shell. It automatically organizes your open windows into a clean, tiled layout - no manual dragging needed. Works on Fedora, Arch, Ubuntu, and any GNOME-based Linux distro.

Extension Homepage
https://github.com/oliwebd/o-tiling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • ui/theme_consistency/apply.js:26
    GLib.file_get_contents(path)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • floating_exceptions/config.js
  • floating_exceptions/main.js
  • floating_exceptions/utils.js

All Versions

Version Status
2.8.13 (6) Active
2.8.11 (5) Rejected
2.5.0 (4) Rejected
2.5.0 (3) Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Unnecessary try-catch wrappers in `system/executor.js`. 2. If you want to override the property in line 81 `system/executor.js`, you should remove the older source before that line. 3. Timeout should be removed on disable and before creating a new one (line 194 `ui/panel_settings.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. Why try-catch when you used `=== 'function'` (`utils/utils.js`)? Please avoid sending large diff. It is hard to review and takes so much time time to review. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions