Review of "O-tiling" version 2.10.8 (26)

Details Page Preview

Auto-tiling extension for GNOME Shell that automatically arranges your windows into clean, efficient layouts, no manual dragging or resizing required. Built for a fast, efficient workflow, intelligently adapts your layout as windows open, close, and change, while giving you the customization and control you need. Make multitasking on GNOME faster, cleaner, and more productive.

Extension Homepage
https://github.com/oliwebd/o-tiling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • floating_exceptions/config.js
  • floating_exceptions/main.js

All Versions

Version Status
2.10.10 (28) Active
2.10.9 (27) Active
2.10.8 (26) Rejected
2.10.7 (25) Active
2.10.7 (24) Rejected
2.10.4 (23) Active
2.10.3 (22) Rejected
2.10.1 (21) Inactive
2.9.21 (20) Inactive
2.9.20 (19) Rejected
2.9.20 (18) Rejected
2.9.18 (17) Rejected
2.9.17 (16) Rejected
2.9.15 (15) Inactive
2.9.12 (14) Active
2.9.9 (13) Rejected
2.9.5 (12) Inactive
2.9.4 (11) Rejected
2.9.4 (10) Rejected
2.9.3 (9) Rejected
2.9.1 (8) Rejected
2.9.0 (7) Rejected
2.8.13 (6) Inactive
2.8.11 (5) Rejected
2.5.0 (4) Rejected
2.5.0 (3) Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Are you storing the system keybindings in gsettings so they can be restored to their original values even after a reboot and disabling the extension (`system/keybindings.js`)? I ask because if you don't, users will lose their keybindings after: 1. Reboot 2. Disable
oliwebd posted a review
You're right, this was a gap. The current implemntation only keeps the original system keybinding in memory. This works during normal disable/enable cycles, but the data is lost after a reboot, logout, or GNOME Shell crash, while the dconf change remains. **My plan for a future version:** Before clearing a conflicting keybinding, the ext will save its original value in a persistent JSON key in its own `Gio.Settings` schema. On `enable()`, it can check for entries left from an unclean shutdown and restore them before handling new conflicts. I haven't implemented this yet. I plan to include it in a future version so keybinding restoration also survives restarts and crashes.
JustPerfection rejected
I'm going to reject it then. If users lose all of those keybindings, they'll definitely be mad at both me and you :)
oliwebd posted a review
Also, most o-tiling users are coming from like Pop Shell or Forge, so they are already familiar with auto-tiling and may have their own default keybindings configured. That's why I'm aware this needs an additional fix for this edge case. I plan to address the persistent keybinding restore in a future version as well.