Review of "O-tiling" version 2.9.20 (19)

Details Page Preview

O-Tiling is a free, open-source auto-tiling extension for GNOME Shell 48, 49, and 50. It automatically organizes your open windows into a clean, tiled layout - no manual dragging n[...]

Extension Homepage
https://github.com/oliwebd/o-tiling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • floating_exceptions/config.js
  • floating_exceptions/main.js

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js
    unlock-dialog declared but disable() was not found

All Versions

Version Status
2.9.21 (20) Active
2.9.20 (19) Rejected
2.9.20 (18) Rejected
2.9.18 (17) Rejected
2.9.17 (16) Rejected
2.9.15 (15) Inactive
2.9.12 (14) Active
2.9.9 (13) Rejected
2.9.5 (12) Inactive
2.9.4 (11) Rejected
2.9.4 (10) Rejected
2.9.3 (9) Rejected
2.9.1 (8) Rejected
2.9.0 (7) Rejected
2.8.13 (6) Inactive
2.8.11 (5) Rejected
2.5.0 (4) Rejected
2.5.0 (3) Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

oliwebd posted a review
Apologies for the big diff.... refactored several doc comments and minor sections along the way.
JustPerfection rejected
Session mode isn't justified for this extension. Using session mode doesn't mean the extension won't be disabled on lock. Even by using the session mode, the extension may get disabled -> re-enabled. That's how GNOME Shell tries to re-base.