Review of "OmniPanel" version 11

Details Page Preview

OmniPanel is a Multi-Monitor advanced window management solution for productivity, featuring configurable zones for windows, smart auto-placement, and automatic tiling. Features: - Top bar on every active screen, including Extensions - Window tiling with Zone designing and auto-placement - Stack specific windows in Zones - Auto-tiling capability without needing to draw zones - Use either the mouse or hotkeys for switching/moving Master your workflow with perfectly organized, highly customizable layouts for uninterrupted multitasking. Includes a feature to dynamically move the GNOME top bar to your active screen. A GNOME native alternative to FancyZones or COSMIC on Pop!_Os Video: https://www.youtube.com/watch?v=c7JNV20OV8k

Extension Homepage
https://github.com/cwittenhttps://extensions.gnome.org/away/https%253A%252F%252Fgithub.com%252Fcwittenberg%252Fomnipanelberg/omnipanel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Previous Reviews on this Version

cwittenberg posted a review
Kindly review this version team - added window tiling functionality - refactored for improved maintainability
JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. What's the reason for `i18n.js`? We already have gettext that can be used in extensions. 3. Any timeouts you are creating should be removed on destroy/disable and also before creating a new one. 4. I see many unnecessary lines of AI generated code here. Some of the try-catch wrappers are not needed since nothing throws in there. Also there are unnecessary `=== 'function'` checks when it is obvious the function will be there. Also, sorry for the delay. The review queue is pact these days. Please join the GNOME Matrix channel. So you can ping the reviewers there for getting fast reviews: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions # REVIEWERS NOTE I didn't fully review this code since unnecessary lines of code detected. Next review should be diff against version 1 (not this review).