Review of "OmniPanel" version 12

Details Page Preview

Multi-monitor productivity with configurable window layouts and a top bar that seamlessly follows your focus.

Extension Homepage
https://github.com/cwittenberg/omnipanel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
14 Unreviewed
13 Rejected
12 Rejected
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

cwittenberg posted a review
- Migrated to native GNOME language get_text (used AI to help do so) I did not know this native feature existed, really cool. - Ensured timer removal where possible - Where possible removed connectObject() and disconnectObject() Thank you in advance.
JustPerfection rejected
1. You are still doing many unnecessary try-catch wrappers. 2. Timeout should be removed on destroy and also before creating a new one (line 319 `layout_storage.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. You don't use destroy to cleanup (line 114 `lifecycle.js`). Also, the destroy/cleanup isn't called on the instance (line 84 `tiling_manager.js`). 4. Selective disable is not allowed: - line 118 `panel_mover.js` - line 312 `stack_manager.js` - line 122 `tiling_manager.js` 5. Remove version from the imports: - `prefs_components.js` - `prefs_guide_about.js` - `prefs_hotkeys.js` - `prefs_tiling.js` - `prefs_topbar.js`