Review of "Context + Window Title" version 50.0 (1)

Details Page Preview

Add a little more text and context to your user experience. Creates a top bar “context” button with the focused window’s icon and title, or an app grid icon if no window is focused. Optionally shows a more customizable clock, the user/host name on the system menu button, and a message on the lock screen. The context button can function both as a toggle from desktop to apps, windows, and back to desktop when clicked, and as an app menu when pressed using the secondary button or long-pressed by touch.

Extension Homepage
https://github.com/erikis/context-window-title

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:90
    console.error(`${NAME} contextButton destroy on disable`, ex)
  • extension.js:107
    console.error(`${NAME} clockLabel destroy on disable`, ex)
  • extension.js:115
    console.error(`${NAME} nameIndicator destroy on disable`, ex)
  • extension.js:141
                    console.error(
                        `${NAME} clockLabel _updateStart on sessionMode`,
                        ex
                    )
  • extension.js:151
                    console.error(
                        `${NAME} contextButton destroy on sessionMode`,
                        ex
                    )
  • extension.js:164
                    console.error(
                        `${NAME} nameIndicator _update on sessionMode`,
                        ex
                    )
  • extension.js:172
                    console.error(
                        `${NAME} clockLabel _updateStop on sessionMode`,
                        ex
                    )
  • extension.js:218
    console.error(`${NAME} lockMessage activate on sessionMode`, ex)
  • extension.js:233
    console.error(`${NAME} contextButton on settings`, ex)
  • extension.js:240
    console.error(`${NAME} clockLabel on settings`, ex)

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • widgets/contextButton.js:576
    this._focusWindow.maximize(Meta.MaximizeFlags.BOTH)
  • widgets/contextButton.js:600
    this._focusWindow.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • widgets/contextButton.js:590
    this._focusWindow.get_maximized()

All Versions

Version Status
50.2 (4) Unreviewed
50.1 (3) Rejected
50.1 (2) Rejected
50.0 (1) Rejected

Previous Reviews on this Version

erikis auto- rejected
Auto-rejected because of new version 50.1 (2) was uploaded