Review of "Context + Window Title" version 50.3 (5)

Details Page Preview

Add a little more text and context to your user experience. Creates a top bar “context” button with the focused window’s icon and title, or an app grid icon if no window is focused. Optionally shows a more customizable clock, the user/host name on the system menu button, and a message on the lock screen. The context button can function both as a toggle from desktop to apps, windows, and back to desktop when clicked, and as an app menu when activated using the secondary mouse button, long-press, or a keyboard shortcut.

Extension Homepage
https://github.com/erikis/context-window-title

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
50.6 (11) Active
50.5 (10) Active
50.4.3 (9) Active
50.4.2 (8) Active
50.4.1 (7) Rejected
50.4 (6) Rejected
50.3 (5) Rejected
50.2 (4) Rejected
50.1 (3) Rejected
50.1 (2) Rejected
50.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `this.#isEnabled` is a bad practice. Please remove that. 2. Please remove the check (line 90 `extension.js`). That falls under selective disable. 3. Please don't wrap `destroy()` with try-catch. Not needed. 4. Better to remove line 28 `widgets/clockLabel.js`. Then rename line 31 to `destroy()` and do `super.destroy()` at the end of that function. Also the same for line 105 `widgets/contextButton.js`. 5. Holding the source ids for different timeouts in the same property is a bad practice (line 169, 195, 204 `widgets/clockLabel.js`). If the timeouts doing the same in different places, creating a helper function is a better approach. 6. You should remove the timeout before creating a new one (line 169, 195, 204 `widgets/clockLabel.js`). 7. Please disconnect signals on destroy (line 252 `widgets/contextButton.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 8. Timeout should be removed on destroy and before creating a new one (line 482, 916 `widgets/contextButton.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions