Review of "Context + Window Title" version 50.5 (10)

Details Page Preview

Add a little more text and context to your user experience. Creates a top bar “context” button with the focused window’s icon and title, or an app grid icon if no window is focused. Optionally shows a more customizable clock, the user/host name on the system menu button, and a message on the lock screen. The context button can function both as a toggle from desktop to apps, windows, and back to desktop when clicked, and as an app menu when activated using the secondary mouse button, long-press, or a keyboard shortcut.

Extension Homepage
https://github.com/erikis/context-window-title

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
50.6 (11) Active
50.5 (10) Active
50.4.3 (9) Active
50.4.2 (8) Active
50.4.1 (7) Rejected
50.4 (6) Rejected
50.3 (5) Rejected
50.2 (4) Rejected
50.1 (3) Rejected
50.1 (2) Rejected
50.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
You should remove all keybindings on lock session. Hold all the binding names in an array. Loop over them to remove in `onSessionMode()`.
erikis posted a review
Thanks. I already remove the keybinding in `onSessionMode()`, though: `Main.wm.removeKeybinding(this.#menuKeybinding);`, which is run when not in user session mode. Looking at the diff here, I noticed it's easy to miss. There is only this one keybinding so I'd prefer not doing an array. But if the point is to do it anyway for clarity, then of course I can change it.
JustPerfection posted a review
You aren't always removing that since you have 418 `extension.js` check.
JustPerfection active
Approved since the return result won't be 0 when the keybinding is added.