Review of "Auto Color Top Bar" version 1

Details Page Preview

Automatically adapts the Top Panel color based on the current wallpaper or lets you choose one manually. It also lets you adjust the panel opacity and manage the Dash color and the desktop's primary background color.

Extension Homepage
https://github.com/baitsart/AutoColor-Top-Bar

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:67
    GLib.file_get_contents(path)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • stylesheet.css
    placeholder stylesheet.css

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:28
    this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:40
        this._settings.connect('changed::auto-color', () => {
            this._applyColor();
        })
  • extension.js:36
        this._settings.connect('changed::color', () => {
            this._applyColor();
        })

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

baitsart auto- rejected
Auto-rejected because of new version 2 was uploaded