Automatically adapts the Top Panel color based on the current wallpaper or lets you choose one manually. It also lets you adjust the panel opacity and manage the Dash color and the desktop's primary background color.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-P-006 warning
unnecessary build and translation artifacts should not be shipped
Package contains files that often should not be shipped for review.
Don't include unnecessary files
Auto Color Top Bar
stylesheet.css
placeholder stylesheet.css
EGO-L-005 warning
owned object references should be released in disable()
Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.
extension.js:48
this._backgroundSettings = new Gio.Settings({
schema_id: 'org.gnome.desktop.background'
})
extension.js:29
this._settings = this.getSettings()
EGO-L-003 warning
signals connected by extension should be disconnected in disable()
Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.
extension.js:52
this._backgroundSettings.connect('changed', () => {
if (this._settings.get_boolean('auto-color'))
this._applyColor();
})
extension.js:43
this._settings.connect('changed::auto-color', () => {
this._applyColor();
})
extension.js:39
this._settings.connect('changed::color', () => {
this._applyColor();
})
| Version | Status |
|---|---|
| 12 | Unreviewed |
| 11 | Rejected |
| 10 | Active |
| 9 | Active |
| 8 | Active |
| 7 | Active |
| 6 | Rejected |
| 5 | Rejected |
| 4 | Rejected |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
1. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Wrong path in xml file. It should end with `AutoColorTopBar` instead of `autocolortopbar` 3. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 4. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 5. Fix the indentations. 6. Disconnect signals in disable (line 39-43, 52 `extension.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 7. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 8. Also null out in disable: ```js this._settings = null; this._backgroundSettings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 9. You already got the instance in enable (line 69 `extension.js`). You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions