Review of "Auto Color Top Bar" version 7

Details Page Preview

Automatically adapts the Top Panel color based on the current wallpaper or lets you choose one manually. It also lets you adjust the panel opacity and manage the Dash color and the desktop's primary background color.

Extension Homepage
https://github.com/baitsart/AutoColor-Top-Bar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:32
        GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
          this._applyColor();
          return GLib.SOURCE_REMOVE;
        })
  • extension.js:63
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
              if (this._settings.get_boolean("auto-color")) this._applyColor();
              return GLib.SOURCE_REMOVE;
            })
  • extension.js:72
          GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
            if (this._settings.get_boolean("auto-color")) this._applyColor();
            return GLib.SOURCE_REMOVE;
          })

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
You can also do `connectObject` for line 71 `extension.js`.